`shorten-links` conflicts with OctoLinker

Please ensure:

• The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Description

It seems OctoLinker will linkies the code and shorten-links kicks in, potentially making the code invalid.

Worth noting that OctoLinker also linkies code blocks in (Markdown) documents (e.g. https://github.com/oakserver/oak#application-middleware-and-context), but Refined GitHub doesn’t process those links.

Screenshot

Note the https:// prefix is stripped

Console errors

No response

Example URL

https://github.com/oakserver/oak/blob/main/deps.ts

Browser(s) used

Chrome

[cheap-glitch]

Second fix: Exclude .octolinker-link from linkify-code

I’ve got a tentative fix for that, but I’m not sure if it’s worth the trouble since RGH is almost always faster than OctoLinker. So the fix should probably happen over there.

Plus the “double link” bug has actually existed for a while (it was mentioned in the body of #4759), but it doesn’t seem to break anything (yet).

[fregante]

I think it’s because both OctoLinker and RGH are linkifying that URL and then shorten-links will shorten OctoLinker’s link. It just depends on who gets there first:

1. Quick fix for now: Also exclude .octolinker-link from shorten-links
2. Second fix: Exclude .octolinker-link from linkify-code
3. Better fix: Exclude links in code from shorten-links… we did this before and we probably lost it in some optimization. The complex part is that some “code” block has comments in it which can have further code. Honestly I think we need tests for this.
4. OctoLinker fix: If it finds a Refined GitHub link, it should replace it