Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Suggest length limit for PR titles

See original GitHub issue

Description

The suggest-commit-title-limit suggests the length of a commit title when a PR is about to be merged.

It would be nice to have a length warning also during creation and editing of the PR (the title field at the top of the page), to warn as early as possible and make it easier to merge things later (could also be a default-off option)

Screenshot

No response

Example URL

https://github.com/refined-github/refined-github/pull/5365

Issue Analytics

State:
Created 2 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

3reactions

fregantecommented, May 20, 2022

Right. I’ll try to rephrase it:

The PR title does not have a limit; the length only ever comes into play in a very specific set of circumstances that happen much later. Linking these two separate events is kind of a mental stretch for a GitHub user who might not even be the one who will merge the PR.

1reaction

fregantecommented, May 19, 2022

Reopened on the basis that super-long PR titles aren’t exactly ideal either, however we can’t show a red color in this case, maybe an orange or yellow is better if available.

A character count wouldn’t be particularly helpful because it cannot/does not include the PR number " (#123) so: at what magic number do you have to stop on the PR #123? It’s not 72, not 70, not 68, etc… so we need to use a similar logic to the commit title, except we silently subtract " (#123)".length from the total.

It’s ok to extend this feature to apply it to PRs and maybe rename the feature