question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`table-input` is not a modal

See original GitHub issue
  1. On this issue’s comment field
  2. Click the table-input button
  3. Click anywhere on the page

The dropdown should close, but it doesn’t.

Kapture 2020-12-14 at 19 44 36

Modals like the “canned replies” automatically closes by design, without any JavaScript. table-input should be modified so it natively closes like the rest of the modals, it should probably never be explicitly closed via JS.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
kidonngcommented, Apr 29, 2021

(For record, the tooltip is added in #3615)

So this is why the table-input button has somehow “awkward” focus, and only shows tooltip when hover the icon instead of the larger button.

The “canned replies” input also doesn’t have a tooltip

Did you mean “Insert a reply”? It does have a tooltip now:

image

But it doesn’t open a modal, you have to click the icon or press <kbd>Esc</kbd> to close it.

Just my random thoughts, doesn’t necessarily mean I want a change.

1reaction
fregantecommented, Dec 17, 2020

Seems like adding a tooltip on the button disrupts the modal functionality

You’re right, that’s because both use :before.

It won’t be accessible, but we can wrap the SVG in a div with the tooltip attribute. Better than nothing at all.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Glue::Table TableInput - AWS CloudFormation
A structure used to define a table. Syntax. To declare this entity in your AWS CloudFormation template, use the following syntax: JSON.
Read more >
Triggering showing of modal from a button in the editor
I want to trigger showing of a modal from a button in a data table row. It seems to try to go to...
Read more >
Unable to render content of the table to the modal in twitter ...
the code works but i want when i click on the submit replication button the content of the table should be in the...
Read more >
Is 'not' a modal verb?
"Not" is not a verb. "Not" isn't really the same part of speech as any other word. It is unique. But if you...
Read more >
MODAL SHAPE - Product Documentation Center
MODAL SHAPE Define Modal Shape Description This option is used when a modal analysis is indicated on the DYNAMIC parameter or during an ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found