Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Verified commits UI is a bit broken

See original GitHub issue

Reproducible on https://github.com/mathiasbynens/dotfiles/commit/adc5b5971649017f4de5b28074e51fcf67ac5b0d

screen shot 2016-05-17 at 12 52 16

The space is too narrow for the Verified badge.

I guess we could restyle that a bit or probably remove the .patch and .diff links if they keep creating problems in that area.

Issue Analytics

State:
Created 7 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

sindresorhuscommented, May 31, 2016

I’m still not sold on #224.

I managed to fix the UI by decrementing the font-size by one pixel for each element, the following:

.full-commit
.full-commit .sha-block
.commit .sha-block, .commit .sha

2reactions

paulmolluzzocommented, May 19, 2016

I guess we could restyle that a bit or probably remove the .patch and .diff links if they keep creating problems in that area.

We might have discussed this before, but is there some icon we can use instead to save space? IIRC, we went through the process of shrinking padding to make more room there, so I don’t know what else we can do except removing content or rearranging the whole area - like a two row layout.

I’m not keen on either scenario, but if anything gets removed it’s the patch/diff links since they’re added by RG.

Another idea: We can use keyboard shortcuts to switch to patch/diff of the commit and get rid of the links entirely. <kbd>+</kbd> for patch, and <kbd>=</kbd> for diff?

Top Results From Across the Web

Verified commits UI is a bit broken · Issue #220 · refined-github ...

I'm open to either shortcuts or icons. I really don't want some of the more obscure things which RG adds to break the...

Git blame broken after commit with no parent - Stack Overflow

To verify this, ask them to run git merge-base HEAD 49d0d22 after the pull — it should come out empty. The commands to...

Is it ever OK to commit non-working code?

Noting the 'working code' is part of the 'dev' branch policy, one should never commit broken code to the dev branch.

Sign commits with GPG - GitLab Docs

Select Commits. Identify the commit you want to review. Signed commits show either a Verified or Unverified badge, depending on the verification status...

GPG signature verification - Hacker News

The part that GitHub implemented (uploading keys to the site, displaying verified signed commits in the UI) looks like it is both.