question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`wait-for-build` throws error on PR page

See original GitHub issue

(Firefox 68.0.2 (64-bit) on Windows 10, plugin version 19.9.2)

Happens for me on for example this PR: https://github.com/fastlane/fastlane/pull/15255

image

19:36:52.676 ❌ wait-for-build content.js:2837:15
19:36:52.702
TypeError: "select_dom_default.a.last(...) is undefined"
    getLastCommit moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:5401
    addEventListener moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:5436
    wait_for_build_init moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:5519
    features_run moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2833
    add moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2880
    onAjaxedPages moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2795
    onAjaxedPagesRaw moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2790
content.js:2838:15
    features_run moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2838
    add moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2880
    onAjaxedPages moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2795
    onAjaxedPagesRaw moz-extension://57b5be31-7fbe-4b7d-bae1-b2f5de44e6b4/content.js:2790

I don’t know if this actually breaks anything, but I guess it should be fixed anyway.


Same on Chrome: image

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
jeronecommented, Sep 4, 2019

Ah yes, I can confirm. It needs to be an unclosed PR.

That selector probably needs to be changed to select.last('.js-commit-group-commits .commit-id').

1reaction
jeronecommented, Sep 4, 2019

I can only reproduce on repos where I am admin or can merge PRs (feature probably only runs there).

I still can’t confirm this error. For example https://github.com/jerone/PackageSize/pull/2, this is an PR and I’m admin of this repo. Checkbox is visible and no errors in console.

commits-pushed does not appear at all, but if I understand the code snippet correctly that is exactly what should not appear for a match, correct?

I’m not familiar with this feature, so I’ll let @fregante answer your questions.

What do you get in the console when you execute the following snippet $$('[id^="commits-pushed"] .commit-id');?

Read more comments on GitHub >

github_iconTop Results From Across the Web

The Pull request build is getting failed, it is not taking new ...
Now, after the PR is approved and build is queued again from Pull request page, it is getting failed and not taking new...
Read more >
[Question] Does waitFor() throw an error when the element is ...
We are using locator().waitFor() and expect an error to be thrown after the default timeout. Instead the test hangs and does not complete....
Read more >
Unable to queue build error with Azure DevOps Pull Request
I'm having a forked repo in ADO with goal to queue validation builds prior merge, and the main repository should be used as...
Read more >
Triggering builds automatically - Bitrise Docs
In this guide, we cover how to set up and manage triggers on the website UI. ... Use the Bitrise Start Build and...
Read more >
Error "Something went wrong" when using "New pull request ...
Bug BCLOUD-18903 - "We were unable to load this page" error when PR is too big ... A "Something went wrong" error appears...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found