Warn about auto-merge being enabled when approving a PR

I often already approve PRs even though I would prefer to get answers to some of my questions in the review. Maybe I should just comment in that case, but well… It regularly happens to me that the PR is landed right away (or some seconds/minutes later) because the PR has been configured to be merged/squashed/rebased automatically.

I think it would be helpful to see some indicator in the “Finish your review” dialog of the Files tab, that makes you aware that the PR will land as a result of your approval.

Since it might be more complex to check the current status and it might change to that state in a few seconds or minutes, in case auto merge is enabled for the PR, I think it makes more sense to just check for that toggle.

1. Include a REAL URL where the feature should appear. e.g. Do you want a feature to appear on the main page of a repo? Paste a link to a repo

I’m not sure what “REAL URL” I should add, the dialog that has the “Approve” button (with quick-review-buttons being active, otherwise option) is only visible for maintainers of a repo and only after a click.

According to the comment below the affected URL would be https://github.com/{org_or_user}/{repository}/pull/{id}/files

[karfau]

Yes, everything you said us correct.

And the more I think about it, the less I think it is a valid way to think about it.

When I approve it, somebody else could still set it to auto-merge afterwards, potentially even without seeing my comments.

So I think it’s a better option to only put a comment review, when I don’t want the PR to be merged.

[fregante]

Being a new GitHub feature if you ping some producer or the CEO on Twitter you might have a good chance at seeing this natively.

Here I think the main issue is finding this piece of information. Perhaps if it’s available on the PR Conversation tab we can cache it preemptively. If someone clicks that automerge while you’re reviewing we can’t find out without polling continuously, which we can’t do.