What to do when the token has expired?
See original GitHub issue_Originally posted by @Dentrax in https://github.com/refined-github/refined-github/issues/5160#issuecomment-990683936_
Are there any error messages logged to console when it happens?
Oh, just saw this on the logs: 🙈
The token seems to be incorrect or expired. Update it in the options.
How would we get notified once Refined GitHub token got expired? I think we can add a small icon that indicated this situation. Furthermore, we can add this case in the FAQ section to remind whether token is expired or not. Wdyt? ❤️
I’m wary of bothering users with popups and notices, so I’d probably treat an expired token the same way as a missing token: Just show a notice in the console and in the options page.
Now the question is: Are we showing “token is expired” in the options page?
@Dentrax what’s in the options page? Were the icons all red?
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (3 by maintainers)
If I remember correctly, the text below the field becomes “🚫 The token is invalid or expired” as soon as it becomes (or is made) invalid.
I could not remember much, but probably the icons were red and there was a warning text as @.cheap-glitch said.
Since checking the token whether it is expired or not in the
Setings > Extensions > Refined GitHub > Preferences
, we had better to move another place to make it more visible to users.What about turning this blue color to red? Or adding a warning icon left next to the notification icon. Wdyt?