[Server thread/WARN] and Crafter Fail inserting into Botania OpenCrate

Issue description:

Crafter inserting into botania:opencrate gives the following warning in server log and autocraft stalls without completing:

[Server thread/WARN] [com.raoulvdberge.refinedstorage.apiimpl.autocrafting.task.CraftingTask]: In a simulation, vazkii.botania.common.block.tile.TileSimpleInventory$SimpleItemStackHandler@5204242d reported that we could insert 1xitem.manaResource@1 but we got 1xitem.manaResource@1 as a remainder

I appreciate the dev team have done a lot of work around the way autocrating works recently. It used to be possible to autocraft into botania opencrates in previous versions, it would be great if this could be made possible again.

What happens:

(as above)

What you expected to happen:

Crafter inserts each ingredient into botania:opencrate as per pattern recipe.

Steps to reproduce:

1. Create a crafting pattern for either botania petal apothecary, botania runic altar or botania agglomeration table
2. Place crafter to insert into botania:opencrate and insert crafting pattern into crafter
3. Order required item …

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: forge-1.12.2-14.23.5.2768-universal
• Refined Storage: refinedstorage-1.6.7.jar

Does this issue occur on a server? [yes/no] yes

If a (crash)log is relevant for this issue, link it here:

[Server thread/WARN] [com.raoulvdberge.refinedstorage.apiimpl.autocrafting.task.CraftingTask]: In a simulation, vazkii.botania.common.block.tile.TileSimpleInventory$SimpleItemStackHandler@5204242d reported that we could insert 1xitem.manaResource@1 but we got 1xitem.manaResource@1 as a remainder

[pastebin/gist/etc link here]

[raoulvdberge]

I know what causes this. I am working on a fix.

[jamesfoster]

@raoulvdberge Doesn’t seem ideal to void items. is it possible to only remove items from storage if they will fit in the destination inventory. Or return to storage anything that wouldn’t fit?

It would also be nice if you tried to insert the remainder on the next crafting tick.