question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

feature request: notification of test maintainer on failure

See original GitHub issue

We would like to have optional notifications sent to the maintainer of a test when the test fails.

@rfm.simple_test
class mytest(rfm.RegressionTest):
    def __init__(self):
        super().__init__()
        self.descr = "A Simple test"
        self.valid_systems = ['cori:knl',
                              'gerty:knl']
        self.valid_prog_environs = ['PrgEnv-intel']
        self.maintainers = ['bgcook@lbl.gov']
        self.notify_maintainers = True

or maybe

self.maintainers = [{'email': 'bgcook@lbl.gov', 'notify' : True}, 'other@lbl.gov']

where non-dict items are treated as "notify" : False.

Is the logging framework the right place to develop something like this? e.g.

logging_config = {
    'level': 'DEBUG',
    'handlers': [
        {
            'type': 'email',
            'level': 'ERROR',
            'format': '[%(asctime)s] %(levelname)s: '
                      '%(check_info)s: %(message)s',
        }
    ]
}

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
vkarakcommented, Jul 8, 2020

Hi @brandongc

I think we also want to make sure this is controllable, maybe via a CLI opt-in option like --notifications=on? I don’t want to get spammed by people using reframe to test their work on our development systems.

That’s pretty straightforward now in ReFrame 3.0. We can combine command line options with configuration parameters and environment variables very easily, so such a feature could easily enabled via different ways.

Another thought is to keep it extensible beyond email. One possibility is to also consider webhooks to enable things like Slack integration.

That’s a valid thing to take into account. Being able to open JIRA tickets directly for example would also be nice as a future extension.

And finally I wonder what context could/should be included in a notification beyond “$test failed”.

Regarding this, we’re working in #1377 in generating a json report for the full run (and as a result for each test). This contains all test-related information, so that could be sent as well and perhaps create a summary of it as the notification body. In fact, when this is merged (hopefully for 3.1), you could have any custom external tool reading that json and sending out notifications at will.

0reactions
vkarakcommented, Jul 8, 2020

Oh, and most probably this feature request will be postponed to 3.2 due to lack of bandwidth currently 😄

Read more comments on GitHub >

github_iconTop Results From Across the Web

Feature request - Notify Slack only on monitoring failure #4274
This channel is suppose to only receive notifications requiring actions. Each monitor has an integration with the slack channel above. Current ...
Read more >
Push notifications triggered by failure states - Pi-hole Userspace
I have seen a few feature requests for notifications, but I'm hoping a more focused approach will help get some traction.
Read more >
Access request notifications are received by both Project ...
An error occurred while retrieving approval data for this merge request. Access request notifications are received by both Project Maintainers ...
Read more >
action #17252: notifications to maintainer on failed modules ...
user story¶. As a test module maintainer I want to get informed about failure occurences so that I do not need to poll...
Read more >
Pull Requests | Atlassian Git Tutorial
Once their feature branch is ready, the developer files a pull request via ... SVN and Git can both automatically send notification emails...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found