Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Generate executable `_job.sh` files

See original GitHub issue

It would be useful to have a configuration setting to generate _job.sh files that are executable. Would this be a potential feature that could be added?

Thanks

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

teojgocommented, Jan 26, 2021

@jg The compile of the check, it is defined here: https://github.com/eth-cscs/reframe/blob/13c372ef7aa5d63f6d74c73f61c4c033c0312d53/reframe/core/pipeline.py#L1165

0reactions

vkarakcommented, Jan 26, 2021

@jgphpc Actually the building phase where @teojgo pointed you has nothing to do with the job script creation. The job script is created by the ShellScriptGenerator here:

https://github.com/eth-cscs/reframe/blob/13c372ef7aa5d63f6d74c73f61c4c033c0312d53/reframe/core/shell.py#L114

Currently, setting the executable bit is handled by the scheduler backends (only the local scheduler does that):

https://github.com/eth-cscs/reframe/blob/13c372ef7aa5d63f6d74c73f61c4c033c0312d53/reframe/core/schedulers/local.py#L63-L64

I think the best solution is to move that responsibility to the shell script generator by adding an option that controls whether to set +x or not. And then we remove this logic from the local backend, which is just a leftover from the past.