Errors running tests after git clone and npm install from master

The tests are failing after cloning and installing the master branch of react-router.

Steps to reproduce

git clone https://github.com/ReactTraining/react-router.git npm install npm run build npm test

Expected Behavior

The tests should pass.

Actual Behavior

The tests are failing, with the first error being:

FAIL modules/__tests__/NavLink-test.js
  ● NavLink › When a <NavLink> is not active › renders child components that use withRouter

    expect(received).toBe(expected) // Object.is equality
    
    Expected value to be:
      true
    Received:
      false

      213 |       );
      214 | 
    > 215 |       expect(ref instanceof WrappedComponent).toBe(true);
      216 |     });
      217 |   });
      218 | 
      
      at Object.<anonymous> (modules/__tests__/NavLink-test.js:215:47)

os: MacOS 10.13.4 node: 10.1.0 npm: 5.6.0

In general it seems that there are lots of issues with how dependencies are being resolved across the mono repo during test execution.

The above error is only the first in several errors that I’m seeing when trying to run the tests… 😕

[pshrmn]

I just tried a fresh build and it looks like lerna builds the website package before the react-router-dom package, which causes a resolve error. The CI build has no issues with this because it skips the website. The website package has a dependency on react-router-dom, so lerna should build react-router-dom first, but obviously that isn’t the case.

[timdorr]

It should. I blew away my local install and it works OK now. It was the lerna weirdness getting in the way before.