Emit 'finish' event on writable streams

Summary

According to the documentation readable streams emit ‘end’ and writable streams emit ‘finish’. However, request seems to always emit ‘end’.

Simplest Example to Reproduce

const fs = require('fs')
const path = require('path')
const request = require('request')


const postReq = request({
    method: 'POST',
    uri: 'http://devnull-as-a-service.com/dev/null',
  })

postReq.on('finish', () => console.log('This should be called!'))

fs
  .createReadStream(path.join(__dirname, 'index.js'))
  .pipe(postReq)

Expected Behavior

Outputs This should be called!

Current Behavior

Does nothing

Your Environment

software	version
request	2.85.0
node	9.10.1
Operating System	macOS

[ad-si]

Sorry, I’m not working with JavaScript anymore. => Haskell That even a project as popular and prevalent as request doesn’t implement the streaming API correctly says a lot about the ecosystem ^^.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.