request should provide a custom util.promisified() version

Code like

request('https://example.com', (error, response, body) => {
  ...
});

can’t be promisified through the usual util.promisify() function in Node 8.x because it goes beyond the standard (error, result) => … callback pattern. It should be pretty easy to fix that by providing a custom implementation that gives e.g. a Promise for a {response, body} object.

I know there’s request-promise, and I can’t really tell how much of request this affects, but it would be awesome if a library that is this popular had even just very simple support for it.

[danielgindi]

This is what should happen:

// npm install --save util.promisified
const boundUtilPromisified = require('util.promisified'); // Provides backwards compatibility

Object.define(request, boundUtilPromisified.custom, {
  enumerable: false,
  value: function () {
        return new Promise((resolve, reject) => {
            arguments[arguments.length] = (err, httpResponse, body) => {
                if (err) 
                    return reject(err);
                resolve({ httpResponse, body });
            };
            arguments.length++;
            request.apply(this, arguments);
        });
  }
});

Then you could use it like this:

let response = await util.promisify(request)('http://url/to/whatever');
// do whatever with response.httpResponse, and response.body

Or even:

let { httpResponse, body } = await util.promisify(request)('http://url/to/whatever');
// do whatever with `httpResponse` and `body`

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.