question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

CircuitBreakerConfig#slidingWindowSize java docs modification

See original GitHub issue

It seems like the Java docs of the, in the title mentioned method, contains some copy-paste lines from the CircuitBreakerConfig#slidingWindow method. Specifically the lines where {@code ...} mentions method parameters which aren’t present. Is that correct? If that’s the case, I’ll gladly open a PR adjusting the docs.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
troleycommented, Oct 17, 2019

With pleasure. Thank you and every contributor for such a great library! 😉

1reaction
troleycommented, Oct 15, 2019

Hi @hexmind & @RobWin . Yes, sure, will review and modify them in a PR tomorrow after work.

Read more comments on GitHub >

github_iconTop Results From Across the Web

CircuitBreakerConfig.Builder (resilience4j-circuitbreaker 1.5.0 ...
Configures the size of the sliding window which is used to record the outcome of calls when the CircuitBreaker is closed. CircuitBreakerConfig.
Read more >
CircuitBreaker - resilience4j
The count-based sliding window is implemented with a circular array of N measurements. If the count window size is 10, the circular array...
Read more >
Not possible to change minimum amount of recorded requests ...
Hi,. you can still configure minimumNumberOfCalls if you are using SlidingWindowType.TIME_BASED to reduce the minimum number of calls per ...
Read more >
Resilience4j Configuration - Apache Camel
Contents ; slidingWindowSize. Configures the size of the sliding window which is used to record the outcome of calls when the CircuitBreaker is...
Read more >
Why to use Circuit Breaker Pattern? - pankajtechblogs
Retry just looks for the api call to succeed, while circuit breaker will ... CircuitBreaker uses a sliding window to store and aggregate...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found