Question regarding resilience4j-spring-cloud2 usage

Resilience4j version: 1.3.1

Java version: 1.8

I have added resilience4j-spring-cloud2, spring-boot-starter-actuator, spring-boot-starter-aop, to pom.xml and also added config server details to bootstrap.properties. At runtime I have changed a property and ran /actuator/refresh, which returned the modified properties as response like below.

[
    "resilience4j.threadPoolBulkhead.configs.default.maxThreadPoolSize"
]

I have also written test endpoint /ping/prop which returns the value of resilience4j.bulkhead.max.thread.pool.size to make sure refresh is working as expected.

@Value("${resilience4j.threadPoolBulkhead.configs.default.maxThreadPoolSize}")
private String maxThreadPoolSize;

However When I have used /actuator/metrics/resilience4j.bulkhead.max.thread.pool.size I don’t see the refreshed value is getting reflected in measurements. I also observed when doing refresh the debugger it’s going to AbstractRefreshScopedBulkheadConfiguration.threadPoolBulkheadRegistry() method though it’s annotated with @RefreshScope. Am I missing something here? I have also checked the demo project https://github.com/resilience4j/resilience4j-spring-cloud2-demo for usage, didn’t find any clue.

FYI, I have some default properties in application.properties, and the plan is to provide different values per environment via centralized configuration.

[dlsrb6342]

Yes. I tested with following changes.

// Added to CheckService
	@Bulkhead(name = "test", type = Type.THREADPOOL)
	public CompletableFuture<Map<String, Number>> checkFuture() {
		return CompletableFuture.supplyAsync(this::check);
	}

Test result

1. Check with API call

▶ curl http://127.0.0.1:8080/checkFuture
{"ThreadPoolBulkhead max thread pool":4,"Bulkhead maxConcurrentCalls":100,"Retry max retry":2,"CircuitBreaker failureRateThreshold":30.0,"RateLimiter limitForPeriod":10}%

// Changed to 10
▶ curl -X POST http://127.0.0.1:8080/actuator/refresh
["resilience4j.thread-pool-bulkhead.configs.default.maxThreadPoolSize"]%

▶ curl http://127.0.0.1:8080/checkFuture
{"ThreadPoolBulkhead max thread pool":10,"Bulkhead maxConcurrentCalls":100,"Retry max retry":2,"CircuitBreaker failureRateThreshold":30.0,"RateLimiter limitForPeriod":10}%

1. Check with actuator metrics. You need to call API once because Bulkhead instance should be re-created.

▶ curl http://127.0.0.1:8080/actuator/metrics/resilience4j.bulkhead.max.thread.pool.size
{"name":"resilience4j.bulkhead.max.thread.pool.size","description":"The maximum thread pool size","baseUnit":null,"measurements":[{"statistic":"VALUE","value":10.0}],"availableTags":[{"tag":"name","values":["test"]}]}%

// Changed to 4
▶ curl -X POST http://127.0.0.1:8080/actuator/refresh
["resilience4j.thread-pool-bulkhead.configs.default.maxThreadPoolSize"]%

▶ curl http://127.0.0.1:8080/checkFuture
{"ThreadPoolBulkhead max thread pool":4,"Bulkhead maxConcurrentCalls":100,"Retry max retry":2,"CircuitBreaker failureRateThreshold":30.0,"RateLimiter limitForPeriod":10}%

▶ curl http://127.0.0.1:8080/actuator/metrics/resilience4j.bulkhead.max.thread.pool.size
{"name":"resilience4j.bulkhead.max.thread.pool.size","description":"The maximum thread pool size","baseUnit":null,"measurements":[{"statistic":"VALUE","value":4.0}],"availableTags":[{"tag":"name","values":["test"]}]}%

[dlsrb6342]

@Romeh Yes right.

Metric response is like following.

▶ curl http://127.0.0.1:8080/actuator/metrics/resilience4j.bulkhead.max.thread.pool.size
{
   "name":"resilience4j.bulkhead.max.thread.pool.size",
   "description":"The maximum thread pool size",
   "baseUnit":null,
   "measurements":[
      {
         "statistic":"VALUE",
         "value":4.0
      }
   ],
   "availableTags":[
      {
         "tag":"name",
         "values":[
            "test"
         ]
      }
   ]
}