Timelimiter for suspendFunction is throwing timeout exception even when the coroutine was cancelled due to a different reason

Resilience4j version: 1.7.0

Java version: 11

Timelimiter for suspendFunction is throwing timeout exception even when the coroutine was cancelled due to different reason.

Suppose due to some business logic, we need to cancel a particular “time limited” suspend function using something like Defferred.cancel(BusinessCancellationException("Do not require this computation anymore")), then this should not be treated as a failure for the timelimiter and should not be converted to a timeout exception but currently it does.

code here converts all cancellation exceptions to timeoutExceptions:

 catch (t: Throwable) {
        if (isCancellation(coroutineContext, t)) {
            val timeoutException = TimeLimiter.createdTimeoutExceptionWithName(name, t)
            onError(timeoutException)
            throw timeoutException
        }

        onError(t)
        throw t
    }

I would propose to specifically do this only for TimeoutCancellationException.

[RobWin]

Unfortunately not. Because Bintray was shut down and we need to migrate the whole release process to Maven Central first 😦 We didn’t have time yet.

[tekener]

After upgrading resilience4j-kotlin to 1.7.1 the issue was fixed for me