setRoomProperties throws an error

The error happens in LateReflections.prototype.setDurations.

Per the ConvolverNode spec, you can only set the buffer once. If you try to set it a second time, it throws an InvalidStateError. Firefox ignores this, and it is only recently implemented in Chrome, which is probably why the problem didn’t show up earlier.

I believe you’ll need to create a new ConvolverNode when you want to change the buffer.

[hoch]

@brianchirls is correct.

This is because of the recent change in Chrome’s Convolver node. We (AudioWG) reverted the spec decision due to the reasonable amount of breakage. Here’s the revert CL for Chrome: https://chromium-review.googlesource.com/c/chromium/src/+/1249275

The revert patch was landed at 71.0.3569.0, so perhaps @drewbitllama needs to make a temporary fix that recreates a convolver node whenever a buffer changes. When 71 hits the stable, we can remove the temporary fix.

[hoch]

This line: https://github.com/resonance-audio/resonance-audio-web-sdk/blob/c69e41dae836aea5b41cf4e9e51efcd96e5d0bb6/src/late-reflections.js#L212

Can be replaced with the following:

this._predelay.disconnect();
this._convolver.disconnect();
this._convolver = this._context.createConvolver();
this._convolver.buffer = buffer;
this._predelay.connect(this._convolver);
this._convolver.connect(this.output);

FYI I have not tested the code locally. (traveling atm)