delete_sized_images() fails with custom upload_to

I have a custom upload_to path:

def file_name(instance, path):
    filename = os.path.basename(path)
    sepFilename = os.path.splitext(filename)
    newFilename = slugify(sepFilename[0]) + sepFilename[1]
    year = str(instance.album.year)
    album_slug = instance.album.slug

    return '/'.join([year, album_slug, newFilename])

#...

class Image(BaseMedia):
    file = VersatileImageField(upload_to=file_name)
    #...

When I run delete_sized_images() the files are not deleted. The problem is the custom path is both appended by get_sized_root_folder() and prepended by sizer_regex.

Example:

def delete_sized_images(self):
    #...
    print(self.get_sized_root_folder()) # __sized__/2015/sd/
    print(self.sizer_regex.pattern)     # 2015/sd/g0043229-(thumbnail|crop)-(\d+)x(\d+)(?:-\d+)?.JPG
    #...

Thank you for your time.

[respondcreate]

Hey @Mortal & @neic –

I thought I released this last month but I forgot to upload it to PyPI! This has been fixed in the 1.6 release which you can now install from PyPI:

$ pip install django-versatileimagefield==1.6

Thanks for finding (and patching!) this bug! 😃

[AlwxSin]

I’m not sure, is my bug related to this, but… I have custom upload_to path. But I’m not using subclassed SizedImage. I have only several rendition key sets in settings like this

VERSATILEIMAGEFIELD_RENDITION_KEY_SETS = {
    'response_image': [
        ('full_size', 'url'),
        ('preview', 'thumbnail__45x45')
    ],
    'comment_image': [
        ('full_size', 'url'),
        ('preview', 'thumbnail__45x45')
    ]
}

And pre-warmer in post_save signal like this

@receiver(post_save, sender=ResponseImage)
@receiver(post_save, sender=CommentImage)
def warm_img(instance, **kwargs) -> None:
    img_warmer = VersatileImageFieldWarmer(
        instance_or_queryset=instance,
        rendition_key_set=instance.RENDITION_KEYSET,
        image_attr='image'
    )
    img_warmer.warm()

instance.RENDITION_KEYSET matches key in settings.

After I read #62 I suggest that my thumbnail images must contain thumbnail word in file name, but they doesn’t. And now I’m not sure, what should I fix. I have no control on thumbnail image file names. Only on original image. Should I subclass ThumbnailImage, redefine it filename_key_regex or filename_key? Or something else?