Axios validateStatus: () => true prevents axios interceptors from executing

RE: #2726 and #2806, setting validateStatus: () => true makes it impossible to intercept response errors at the axios level (e.g. for automatically retrying 401 responses with updated auth tokens, logging, etc.)

Perhaps catching exceptions thrown by the axios request/response and forwarding the response would offer greater flexibility. This way axios interceptors can still execute and the client can still handle failed responses.

I don’t know if this covers all cases, but here’s a possible implementation:

Original code:

getItemById(id: number): Promise<Item> {
    let url_ = this.baseUrl + "/items/{id}";
    if (id === undefined || id === null)
        throw new Error("The parameter 'id' must be defined.");
    url_ = url_.replace("{id}", encodeURIComponent("" + id));
    url_ = url_.replace(/[?&]$/, "");
    let options_ = <AxiosRequestConfig>{
        validateStatus: () => true,
        method: "GET",
        url: url_,
        headers: {
            "Accept": "application/json"
        }
    };
    return this.instance.request(options_).then((_response: AxiosResponse) => {
        return this.processGetItemById(_response);
    });
}

Updated code:

getItemById(id: number): Promise<Item> {
    let url_ = this.baseUrl + "/items/{id}";
    if (id === undefined || id === null)
        throw new Error("The parameter 'id' must be defined.");
    url_ = url_.replace("{id}", encodeURIComponent("" + id));
    url_ = url_.replace(/[?&]$/, "");
    let options_ = <AxiosRequestConfig>{
        // no more validateStatus: () => true,
        method: "GET",
        url: url_,
        headers: {
            "Accept": "application/json"
        }
    };
    return this.instance.request(options_).catch((_error: any) => {
        // if it's an axios error with response, forward the response for processing, 
        // otherwise just throw because the process method won't be able to handle it anyway
        if (isAxiosError(_error) && _error.response) {
            return _error.response
        } else {
            throw _error
        }
  }).then((_response: AxiosResponse) => {
        return this.processGetItemById(_response);
    });
}

where isAxiosError is a simple type guard:

function isAxiosError(obj: any): obj is AxiosError {
    return obj.isAxiosError === true;
}

[bsell93]

@GordonBlahut I did think of that. The issue I had is that I have an interceptor that I want to run on every api call to check for 401 and will attempt to refresh the access token. I didn’t want to have to pass in a new instance of axios into each instantiation of each client when they all needed the same interceptor.

[GordonBlahut]

@bsell93 You can pass an axios instance into the client constructor as well. That way you can wire-up any interceptors on the axios instance outside of the client and avoid messing around with the generated code in case you need to re-generate it periodically.