"Uncaught Error: ko.cleanNode: An already cleaned node was removed from the document" after upgrade 1.1

Hello,

After upgrade from last rc to 1.1 rtm custom control (bootstrap-select) not working.

Its similar in dotvvm contrib repo.

ko.bindingHandlers["bootstrap-select"] = {
  init: function (element, valueAccessor, allBindingsAccessor) {
    $(element).addClass('selectpicker').selectpicker({
      width: '100%',
      actionsBox:true,
      liveSearch: true,
      showSubtext: true,
      selectedTextFormat: 'count'
    });

    var refreshHandler = function () {
      $(element).selectpicker('refresh');
    };

    ko.utils.domNodeDisposal.addDisposeCallback(element, function () {
      $(element).selectpicker('destroy');
    });
    dotvvm.events.afterPostback.subscribe(refreshHandler);
  },
  update: function (element, valueAccessor, allBindingsAccessor) {
    if ($(element).is('select')) {
      var selectPickerOptions = allBindingsAccessor().selectPickerOptions;
      if (typeof selectPickerOptions !== 'undefined' && selectPickerOptions !== null) {
        $(element).prop('disabled', selectPickerOptions.isDisabled());
        if (selectPickerOptions.title) {
          $(element).prop('title', selectPickerOptions.title());
        }
      }
      if (ko.isObservable(valueAccessor())) {
        if ($(element).prop('multiple') && $.isArray(ko.utils.unwrapObservable(valueAccessor()))) {
          ko.bindingHandlers.selectedOptions.update(element, valueAccessor);
        } else {
          ko.bindingHandlers.value.update(element, valueAccessor);
        }
      }
      $(element).selectpicker('refresh');
    }
  }
};

[djanosik]

Ok, I have some good and some bad news.

Good news:

• Knockout cleans the element and all of its descendants
• It also calls jQuery’s cleanData which frees all event handlers and other data
• We don’t need to care about this in BusinessPack

Bad news:

• bootstrap-select also removes some other elements in it’s destroy method that are not descendants of the element. They will not get cleaned-up properly if you don’t call the destroy method.

@martinsura You may need to clean-up some elements yourself.

[tomasherceg]

Closing because there is no reasonable way to solve this on DotVVM side. We need the newest Knockout version and removing the cleanNode check would cause another issued.