Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Routing priority broken

See original GitHub issue

Previously, when a match is found, no other routes are triggered. Now multiple routes are firing.

I noticed this updating from riot 2.3.18 -> 2.5.0. It appears to be caused by changes in riot observable, because it works correctly if I roll that back. Nothing in this route repo has changed in a while.

Example:

route('/post/*.amp.html', function() { /* */ })
route('/post/*', function() { /* */ })

Given the url: /post/title-of-my-post The expected result is for the second route to trigger. The actual result is both get triggered, and also appears to be a race condition of which one gets triggered first.

Issue Analytics

State:
Created 7 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

GianlucaGuarinicommented, Aug 24, 2016

@artstar no we are removing the fat from riot and events namespacing was causing performance issues and other several issues in the router. If you want to use this feature i guess you can do it with probably 10 lines of code in a mixin. Let me know if you need help

0reactions

artstarcommented, Aug 24, 2016

So good feature was removed:( Are there any plans to add event namespacing back?