Feature request: close modal dialog by clicking outside

Hi! Me again.

I’m still playing with your examples repo and recently I found out that pl.treksoft.kvision.modal.Dialog cannot be closed by just clicking outside.

I’ve tried to implement this by myself (via jQuery bindings), but failed, because I don’t know enough jQuery =/

Can you implement this by additional flag in Dialog or Modal classes? Or maybe it’s better to add event handler with something like clickOutside? I mean this:

onEvent {
    clickOutside = {
        hide()
    }
}

Thank you.

[rjaros]

You have found a bug in the Dialog class. The order of constructor parameters scrollable, centered and escape is mixed up. So at the moment you can create your Dialog with scrollable = true and it will work 😉 Fix is on the way.

[rjaros]

Released with 3.11.0