Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

KVision development

See original GitHub issue

Hi,

I’m opening this issue to get feedback about some development decisions.

I’m going to drop dependency on kotlin-observable-js project, which seems to be over complicated and constantly causes errors in my IntelliJ IDE. I’ve created a new ObservableList implementation, which is already pushed to master. It’s very simple implementation, backed by standard MutableMap, which seems to be stable and efficient.

This new implementation will be used in DataContainer and Tabulator components from the next release. All projects using com.lightningkite.kotlin.observable.list.ObservableList would need to migrate to a new class.

If someone has problems with this change - let me know.

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:20 (14 by maintainers)

Top GitHub Comments

2reactions

mpetuskacommented, Jul 10, 2019

Seems to be the right way to go. The less dependencies the better.

1reaction

rjaroscommented, Jul 24, 2020

While preparing for Kotlin 1.4 I’ve decided to change the way to workaround KT-34287 issue. In 3.11.2 I’ve moved the assets used by KVision from maven jar artifacts to the separate NPM project. This change allows to greatly simplify application build files. All kvision-examples projects have been refactored and simplified. I’ve also removed some unnecessary options (including -Pprod=true parameter, which is not required anymore). The previous build files should work fine without any changes as well, but I recommend everyone to make these changes as well for better readability, performance and compatibility with the future 1.4 release.