Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FieldTemplate children are in an array

See original GitHub issue

Prerequisites

I have read the documentation;
In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
Ideally, I’m providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description

Since release 1.2.0 (and more specifically #1118), children passed to FieldTemplate are in an array.

Steps to Reproduce

Open the playground on the Simple example.
Using the React Developer Tools, inspect the first FieldTemplate component and its props.

Expected behavior

children should be a node.

Actual behavior

children is an Array with 2 extra null items.

Version

1.2.0

Issue Analytics

State:
Created 5 years ago
Reactions:3
Comments:10 (6 by maintainers)

Top GitHub Comments

1reaction

ivarprudnikovcommented, Apr 21, 2020

It depends and in theory could be a breaking change. If anyone was cloning props.children through cloneElement() and doing something with contents then it will break after merge. Because developer will get one fragment instead of field along with optional anyOf, oneOf placeholders. But I do not know if anyone would do that ever.

Also it is not clear what issue creator @mlbstrm was doing with children for this to be an issue at all. Same question could be asked @ketysek as he mentioned that was a problem for his field templates.

In addition to the above if this is something meant only for v2 then PR could be merged. v2 implies there are breaking changes anyway.

0reactions

epicfaacecommented, Apr 25, 2020

fixed by #1709