Incorrect validation of required child properties of optional properties?

Prerequisites

• [x ] I have read the documentation;
• [x ] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
• Ideally, I’m providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description

Form validation fails if a required child property of an optional object property is missing.

Steps to Reproduce

Add the following property schema to the “Simple” example in the playground:

    "address": {
      "type": "object",
      "properties": {
        "street": {
          "type": "string"
        },
        "zip": {
          "type": "string"
        }
      },
      "required": ["zip"]
    }

Submit the form without entering any address data

Expected behavior

Because address is optional and I did not enter any address, validation should succeed and the produced form should have no address property.

Actual behavior

Validation fails because the required zip property is missing.

Version

3.2.1

[dieseldjango]

It also looks like the whole way ‘required’ is handled needs reworking. The isRequired() method in ObjectField simply looks at the required property on the schema. The problem is that a ‘required’ property on an optional nested schema is not necessarily required. It would be better to simply rely on ajv validation so this code isn’t basically repeating validation logic that’s correctly implemented in ajv.

[pkcpkc]

The “required” attribute is misinterpreted, when an NOT required element contains required element itself.

Checking out this example: An object with “name” (obligatory) and “link” (mandatory); the editor does NOT accept leaving “link” empty, because its inner fields are obligatory.

{ "title": "My Test", "description": "My description", "type": "object", "properties": { "name": { "description": "The name of the menu item", "type": "string" }, "link": { "$ref": "#/definitions/link" } }, "additionalProperties": false, "required": [ "name" ], "definitions": { "target": { "enum": [ "article", "push", "link", "dataprivacy", "licenses", "stage" ] }, "link": { "type": "object", "properties": { "url": { "type": "string" }, "target": { "$ref": "#/definitions/target" } }, "required": [ "url", "target" ] } } }

Possible but ugly workaround: "link": { "oneOf": [ {"type": "null"}, {"$ref": "#/definitions/link"} ] }