Failing tests on Python 3.5

On Ubuntu 16.04 with Python 3.5.2. This isn’t the target platform obviously but I still think the tests should either skip or succeed.

============================================================= FAILURES ==============================================================
_________________________________________________________ test_i2c_cleanup __________________________________________________________

    def test_i2c_cleanup():
        serial = i2c(bus=smbus, address=0x9F)
        serial.cleanup()
>       smbus.close.assert_called_once()

tests/test_serial.py:71: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <Mock name='mock.close' id='139995073637848'>, name = 'assert_called_once'

    def __getattr__(self, name):
        if name in {'_mock_methods', '_mock_unsafe'}:
            raise AttributeError(name)
        elif self._mock_methods is not None:
            if name not in self._mock_methods or name in _all_magics:
                raise AttributeError("Mock object has no attribute %r" % name)
        elif _is_magic(name):
            raise AttributeError(name)
        if not self._mock_unsafe:
            if name.startswith(('assert', 'assret')):
>               raise AttributeError(name)
E               AttributeError: assert_called_once

/usr/local/lib/python3.5/unittest/mock.py:583: AttributeError
_________________________________________________________ test_spi_cleanup __________________________________________________________

    def test_spi_cleanup():
        serial = spi(gpio=gpio, spi=spidev, port=9, device=1)
        serial.cleanup()
        verify_spi_init(9, 1)
>       spidev.close.assert_called_once()

tests/test_serial.py:109: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <Mock name='mock.close' id='139995073628592'>, name = 'assert_called_once'

    def __getattr__(self, name):
        if name in {'_mock_methods', '_mock_unsafe'}:
            raise AttributeError(name)
        elif self._mock_methods is not None:
            if name not in self._mock_methods or name in _all_magics:
                raise AttributeError("Mock object has no attribute %r" % name)
        elif _is_magic(name):
            raise AttributeError(name)
        if not self._mock_unsafe:
            if name.startswith(('assert', 'assret')):
>               raise AttributeError(name)
E               AttributeError: assert_called_once

/usr/local/lib/python3.5/unittest/mock.py:583: AttributeError
___________________________________________________________ test_display ____________________________________________________________

    def test_display():
        device = sh1106(serial)
        serial.reset_mock()
    
        recordings = []
    
        def data(data):
            recordings.append({'data': data})
    
        def command(*cmd):
            recordings.append({'command': list(cmd)})
    
        serial.command = Mock(side_effect=command)
        serial.data = Mock(side_effect=data)
    
        # Use the same drawing primitives as the demo
        with canvas(device) as draw:
            baseline_data.primitives(device, draw)
    
>       serial.data.assert_called()

tests/test_sh1106.py:35: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <Mock name='mock.data' id='139995111772848'>, name = 'assert_called'

    def __getattr__(self, name):
        if name in {'_mock_methods', '_mock_unsafe'}:
            raise AttributeError(name)
        elif self._mock_methods is not None:
            if name not in self._mock_methods or name in _all_magics:
                raise AttributeError("Mock object has no attribute %r" % name)
        elif _is_magic(name):
            raise AttributeError(name)
        if not self._mock_unsafe:
            if name.startswith(('assert', 'assret')):
>               raise AttributeError(name)
E               AttributeError: assert_called

/usr/local/lib/python3.5/unittest/mock.py:583: AttributeError

[thijstriemstra]

Fixed with #77.

[thijstriemstra]

Here’s Travis showing the same error on Python 3.5 (only): https://travis-ci.org/rm-hull/ssd1306/jobs/182130845