Problem about SSD1351 device color format converting

Class: luma.oled.device.ssd1351 Funtion: display

Origin:

for r, g, b in self.framebuffer.getdata():
    if not(r == g == b == 0):
        # 65K format 1
        buf[i] = r & 0xF8 | g >> 5
        buf[i + 1] = g << 5 & 0xE0 | b >> 3
    i += 2

This code try to convert color RGB(888) to color 65K(565) Convert: rrrrrrrr,gggggggg,bbbbbbbb -> rrrrr ggg,ggg bbbbb when deal with the green byte, bit 76543210 should be convert to 765,432 but actually we get 765,210, the green color changed randomly.

The correct code is:

for r, g, b in self.framebuffer.getdata():
    if not(r == g == b == 0):
        # 65K format 1
        buf[i] = r & 0xF8 | g >> 5
        buf[i + 1] = g << 3 & 0xE0 | b >> 3
    i += 2

green byte just need to left shift by 3, not 5

[rm-hull]

2.5.1 released onto PyPi with this fix in

[rm-hull]

also note that SSD1331 driver is similarly affected