_runNativeCommand called with wrong arguments

Describe the bug On Android I’m getting warning that TypeError: args.unshift is not a function.

I investigated, and and found that NativeBridgeComponent calls _runNativeCommand with three arguments here in _runPendingNativeCommands.

MapView overrides _runNativeCommand here and will treat nativeRef as args, which is wrong.

I’m using latest master branch.

To Reproduce

Not needed, as the bug us clearly in the code.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

• Platfrom: [e.g. Android, iOS]
• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• SDK Version [e.g. 22]
• React Native Version [e.g. 0.59]

Additional context Add any other context about the problem here.

[ShepelE]

Hi! maps/javascript/components/NativeBridgeComponent:64 it accepts the args, but args is not an array, it’s a similar structure and it doesn’t have unshift method so change the block to:

      if (isAndroid()) {
        // https://github.com/react-native-mapbox-gl/maps/issues/326
        // TypeError: args.unshift is not a function
        // fix: args is not an array, so need to perform it into real array
        const _args = [];
        for (let i=0; i<args.length; i++) {
          _args.push(args[i]);
        }

        return new Promise(resolve => {
          callbackIncrement += 1;
          const callbackID = `${methodName}_${callbackIncrement}`;
          this._addAddAndroidCallback(callbackID, resolve);
          _args.unshift(callbackID);
          runNativeCommand(this._nativeModuleName, methodName, nativeRef, _args);
        });
      }

[makirby]

Yeah apologies the class work makes no difference. Yeah that’s the flow that II observed when I was debugging this the other day.

I went with a simple rename patch just like #272 which is running in production for us now.