Plugin backstage-plugin-github-pull-requests not persisting session on refresh

Expected Behavior

Session should persist on refresh of the page and not prompt login.

Current Behavior

Github login is prompted upon opening the plugin. After login, refreshing the page does not persist authentication session, and prompts for another login. Navigation to different pages in the app persists the session.

Steps to Reproduce

1. Install backstage-plugin-github-pull-requests.
2. Follow Github Auth setup as noted here.
3. Follow implementation instructions as noted here:

// packages/app/src/components/catalog/EntityPage.tsx
import { EntityGithubPullRequestsContent } from '@roadiehq/backstage-plugin-github-pull-requests';
...

const serviceEntityPage = (
  <EntityLayout>
    ...
    <EntityLayout.Route path="/pull-requests" title="Pull Requests">
      <EntityGithubPullRequestsContent />
    </EntityLayout.Route>
    ...
  </EntityLayout>

1. Navigate to the page, get prompted for authentication by github.
2. Successfully see pull request plugin rendered after login.
3. Refresh the page, prompting login again.

Context

I also implemented Github login as a test, and had no issues with persisting the auth session on refresh. Wanted to eliminate the possibility that this was by design first.

Your Environment

• @backstage/plugin-catalog-react version: 0.6.11
• @backstage/integration version: ^0.7.1
• @roadiehq/backstage-plugin-github-pull-requests version: 1.3.3

[kissmikijr]

A fix got merged to backstage/backstage master for this issue. I’ll close this ticket

[kissmikijr]

Yes I can repro with the Github App, however, I don’t think the issue is in this plugin, we just use the auth tokens from the core backstage backend. If you go to settings->authentication providers you can see that the whole application is going to be logged out of github after a refresh. I’ll check to make sure, but I think we will need to fix this somewhere else than in this plugin.