Build broke with 4.13.0 (sorry, this is a weird report)
See original GitHub issueI know this is unhelpful and annoying, but… my build broke with 4.13.0. And all I know for sure is that 4.12.1 fixes it.
My large and unrelated application that is not a simple test app (sorry!) silently fails to produce a webpack output js file when using 4.13.0. webpack claims success, but… the file does not exist.
How could this be your fault? I surely don’t know! I looked at the differences between 4.12.1 and 4.13.0 and I was not enlightened.
So I’d be very “uh… not my bug” if I were you, but if this turns out to be the first bug report of many then perhaps something is odd after all.
The good news is, the project that falls over is at least open source, and I can answer questions about the rest of its webpack config and so on.
This procedure will reproduce the issue:
# WORKS FINE, with 4.12.1
git clone https://github.com/apostrophecms/a3-demo
cd a3-demo
npm install
npm install vue-material-design-icons@4.12.1
NODE_ENV=production node app @apostrophecms/asset:build
# BUT THEN BLOWS UP, with 4.13.0
npm install vue-material-design-icons@4.13.0
NODE_ENV=production node app @apostrophecms/asset:build
(You’ll get an error that apos-build.js does not exist, even though it’s the configured output file of the build)
I found the module responsible by trial and error.
(I structured the reproduction instructions above so that they should still succeed and fail in that order even after we temporarily pin our dependency to 4.12.1.)
We’re currently pinned on webpack 5.44.x, but I tried latest with the same result.
Thanks for your time.
Issue Analytics
- State:
- Created 2 years ago
- Comments:15 (6 by maintainers)
Top GitHub Comments
@a-kriya Ah, nice find… I hate when people use GitHub for listing changes but not git itself 🙈
Going forward I’ll publish breaking changes when icons change.
@robcresswell Templarian/MaterialDesign#5409 lists all the icons that were removed and renamed. These PDF ones had Adobe Acrobat logo so they were intentionally removed.
In the above linked post, they mention that they’re not following semver, so you will likely have to manually bump up major for anything breaking.