Translation async provider fallback

I’m using the module into a project, loading the JSON files asynchronously from an external web API.

It would be nice having a fallback when the API doesn’t respond for any reason. At this moment, the LocalizationService just prints an error to the console on the getTranslation() method, but the method itself returns void so there’s no way of telling whether the async load was successful or not.

Maybe returning an Observable<boolean> would allow to define a fallback static object on loading error?

What do you think? Would you find this useful? What would be your preferred way of implementing this? I can try to put together a PR if you want me to.

Thanks and regards.

[robisim74]

I made a commit https://github.com/robisim74/angular-l10n/commit/823e0091de562a7e8d6c917f1a7a2b39d939f8e5 to add a translationError event and to add a new AddWebAPIProvider method to the configuration.

I’m going to release a new version by Monday.

Greetings,

Roberto

[davguij]

@robisim74 Sounds good. Either way, the point is being able to notify subscribers of a possible HTTP error. I’ll fork and try to come up with something later today / tomorrow and will let you know.