Refactor Bug List

I’m going to keep this updated with any issues (as replies) I find relating to the new compiler while I move my game across.

---

Static Field Emit

    function ZStats.new(...)
        local self = setmetatable({}, ZStats)
        self:constructor(...)
        return self
    end
    ZStats.ZERO = ZStats.new({}, 0)
    ZStats.BASE = ZStats.new({}, 1)
    function ZStats:constructor(stats, defaultStatAmount)
        if defaultStatAmount == nil then defaultStatAmount = 0 end
        self.mStrength = ((stats.Strength ~= nil) and stats.Strength or defaultStatAmount);
        self.mEndurance = ((stats.Endurance ~= nil) and stats.Endurance or defaultStatAmount);
        self.mIntellect = ((stats.Intellect ~= nil) and stats.Intellect or defaultStatAmount);
        self.mSpirit = ((stats.Spirit ~= nil) and stats.Spirit or defaultStatAmount);
        self.mAgility = ((stats.Agility ~= nil) and stats.Agility or defaultStatAmount);
        self.mCriticalStrike = ((stats.CriticalStrike ~= nil) and stats.CriticalStrike or defaultStatAmount)
    end

Static fields should be after constructor, as in this instance - constructor isn’t defined and Lua throws an error due to this.

---

This can be worked around by moving the static fields below the constructor, but it should always have the constructor first regardless.

---

Bug List

Functions

• Hoisting of async functions incorrect when it calls itself

Classes

• Static Field Emit

Objects

• Spread on undefined value

Indexing

• Alias for Roact.Children in object destructuring results in invalid offset addition to Roact.Children.

Macros

• Return value for Push incorrect
• Array splice doesn’t work
• Use of string.includes emits invalid code

[brianush1]

Use of string.includes emits invalid code

https://osyrisrblx.github.io/playground/#code/A4JwlgdgLgFARAQwM4BM4DpIGMA2BXFAUyXiTgEpyBuAKCA

print("asd".includes("s"));

The code generated for this segment is erroneous:

-- Compiled with roblox-ts v0.4.0
print(("asd"):includes("s"))
return nil

[Vorlias]

Return value of push is incorrect

https://osyrisrblx.github.io/playground/#code/MYewdgzgLgBFCm0CCAnFBDAnjAvDA2gEQAS8ANmSIQLoDcAUPaJLAJYAmAHrnIlKhkwA6AA4BXCAAsAFIUms4k+CniEAlAxEpWYKNI6cNQA

const testArray = ["Hello"];

const idx = testArray.push("hi there");
print(idx);

The expected output should be 2, as it’s the second element. 3 is given instead.

Incorrect emit:

-- Compiled with roblox-ts v0.4.0
local testArray = { "Hello" }
-- ▼ Array.push ▼
testArray[#testArray + 1] = "hi there"
-- ▲ Array.push ▲
local idx = #testArray + 1
print(idx)

Corrected emit:

-- Compiled with roblox-ts v0.4.0
local testArray = { "Hello" }
-- ▼ Array.push ▼
testArray[#testArray + 1] = "hi there"
-- ▲ Array.push ▲
local idx = #testArray
print(idx)