Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Compilation warning on newer node versions: v8 has a new ArrayBuffer BackingStore API

See original GitHub issue

I get this output by node-gyp rebuild (invoked using scripts/build.sh) on Node version v14.10.1:

../src/rcl_bindings.cpp: In function ‘Nan::NAN_METHOD_RETURN_TYPE rclnodejs::CreateArrayBufferFromAddress(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/rcl_bindings.cpp:1330:70: warning: ‘static v8::Local<v8::ArrayBuffer> v8::ArrayBuffer::New(v8::Isolate*, void*, size_t, v8::ArrayBufferCreationMode)’ is deprecated: Use the version that takes a BackingStore. See http://crbug.com/v8/9908. [-Wdeprecated-declarations]
 1330 |                            v8::ArrayBufferCreationMode::kInternalized);
      |                                                                      ^
In file included from /home/felix/.cache/node-gyp/14.10.1/include/node/node.h:67,
                 from ../node_modules/nan/nan.h:56,
                 from ../src/rcl_bindings.hpp:18,
                 from ../src/rcl_bindings.cpp:15:
/home/felix/.cache/node-gyp/14.10.1/include/node/v8.h:5169:29: note: declared here
 5169 |   static Local<ArrayBuffer> New(
      |                             ^~~
../src/rcl_bindings.cpp:1330:70: warning: ‘static v8::Local<v8::ArrayBuffer> v8::ArrayBuffer::New(v8::Isolate*, void*, size_t, v8::ArrayBufferCreationMode)’ is deprecated: Use the version that takes a BackingStore. See http://crbug.com/v8/9908. [-Wdeprecated-declarations]
 1330 |                            v8::ArrayBufferCreationMode::kInternalized);
      |                                                                      ^
In file included from /home/felix/.cache/node-gyp/14.10.1/include/node/node.h:67,
                 from ../node_modules/nan/nan.h:56,
                 from ../src/rcl_bindings.hpp:18,
                 from ../src/rcl_bindings.cpp:15:
/home/felix/.cache/node-gyp/14.10.1/include/node/v8.h:5169:29: note: declared here
 5169 |   static Local<ArrayBuffer> New(
      |                             ^~~```

I didn’t include it in #734 as I don’t really know any v8 internals.