Daily rotation is completely broken

Specifying daily as the frequency is completely broken. It will create a new logfile every minute.

The culprit is here, which triggers every minute because getDate always returns the current minute for daily rotation.

As I find the code very hard to read and understand and the test coverage evidently isn’t sufficient, I’ve decided not to make a pull request - this would be likely to break some other piece of functionality.

[pdesterlich]

it’s not clearly documented, but if you set a date_format in options you can have a log file for each day

example:

var accessLogStream = require('file-stream-rotator').getStream({
  filename   : logDirectory + '/access-%DATE%.log',
  frequency  : 'daily',
  verbose    : false,
  date_format: 'YYYYMMDD'
});

[rogerc]

not seeing any errors in latest release planned this week so closing this issue