Class names should be more unique or assignable
See original GitHub issueI would advise changing class names that are used to something more unique. Or even make them customisable. For example these are pretty common and can be already used in any kind of a project: outer-container
, inner-container
, content-wrapper
.
That’s what I encountered. The script just doesn’t work because those already have assigned height, width, etc.
Issue Analytics
- State:
- Created 5 years ago
- Reactions:1
- Comments:20 (10 by maintainers)
Top Results From Across the Web
Java class naming conventions, rules, and best practice
The aim of this article is to put in one place answers for the most popular questions around Java class name conventions and...
Read more >Best Practices for ID and Class Names
Best Practices for ID and Class Names · 1. Keep Use of IDs and Classes to a Minimum · 2. Use Functional ID...
Read more >How to assign multiple classes to an HTML container?
This name must be unique in a document. class = cdata-list [CS] This attribute assigns a class name or set of class names...
Read more >Subclassing and Inheritance - Learning Java, 4th Edition ...
Subclassing and Inheritance Classes in Java exist in a hierarchy. A class in Java can be declared as a subclass of another class...
Read more >Class.isInstance vs Class.isAssignableFrom and instanceof
In this quick tutorial, we're going to take a look at the difference between instanceof, Class.isInstance, and Class.isAssignableFrom.
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@rommguy So, I’ve got it working. Had to make a bit of refactoring so it would properly pass linting. Probably it’s going to be a little bit messy. Anyway, you’ll have a look for yourself when I submit it. Gonna do it today. Thanks for the package btw, it’s really cross-browser.
Hi guys, I’ll probably merge it in the next few days. I will also separate the example build from the build script, so you won’t have any trouble running the build script. @orangecoloured the eslint errors are something related to your environment. I don’t have any errors when running eslint on the project, that’s one of the reasons I didn’t want to merge the first PR.