ProxyCommand none breaks connection

According to man ssh_config, setting ProxyCommand none should disable the option entirely.

asyncssh interprets none as the command to execute as proxy command, thus returning the following error:

File "asyncssh/asyncssh/connection.py", line 434, in _connect
  conn = await _open_proxy(loop, proxy_command, conn_factory)
File "asyncssh/asyncssh/connection.py", line 352, in _open_proxy
  _, tunnel = await loop.subprocess_exec(_ProxyCommandTunnel, *command)
File "/usr/lib/python3.10/asyncio/base_events.py", line 1670, in subprocess_exec
  transport = await self._make_subprocess_transport(
File "/usr/lib/python3.10/asyncio/unix_events.py", line 207, in _make_subprocess_transport
  transp = _UnixSubprocessTransport(self, protocol, args, shell,
File "/usr/lib/python3.10/asyncio/base_subprocess.py", line 36, in __init__
  self._start(args=args, shell=shell, stdin=stdin, stdout=stdout,
File "/usr/lib/python3.10/asyncio/unix_events.py", line 800, in _start
  self._proc = subprocess.Popen(
File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
  self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.10/subprocess.py", line 1847, in _execute_child
  raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'none'

[ronf]

Thanks very much - the fix for this is now available in the “develop” branch as commit https://github.com/ronf/asyncssh/commit/aaf7d2910993a87d059bddcbf04c42df3d017ca9 and will be included in the next release.

[dtrifiro]

Hi @ronf,

thanks for the suggestions. I agree that would be cleaner, I updated the PR accordingly.

As for the use case: I’m assuming having ProxyCommand none is useful for cases in which you need a proxy to access all resources but a few internal ones, something like this:

    
Host <internal host>
    ProxyCommand none
    
Host *
    ProxyCommand <proxy command>

edit: swapped ordering, leaving the more generic option last