question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`flow-coverage-report` should work with `// @flow strict` declaration

See original GitHub issue

When I run the following command:

flow-coverage-report -i 'src/**/*.js' -i 'src/**/*.jsx' -t html -t json -t text

I get this error for any file with a // @flow strict header:

Error while generating Flow Coverage Report: Error: Unexpected missing flow annotation on src/.../foo.js Error: Unexpected missing flow annotation on src/.../foo.js

When I remove ‘strict’ from that header comment, the errors moves on to another file with it. This is syntax officially supported by flow (https://flow.org/en/docs/strict/) so expected it to work with this tool.

Issue Analytics

  • State:open
  • Created 5 years ago
  • Reactions:7
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
smirnowldcommented, Oct 4, 2018

This can be closed now that 0.6.0 is released. I’ve tested it and it seems to work.

0reactions
LoganBarnettcommented, Oct 5, 2018

We just switched our codebase over to @flow strict and verified flow-coverage-report works great with it. Thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Flow Coverage
The coverage command provides a metric of the amount of checking that Flow has performed on each part of your code. A program...
Read more >
flow-coverage-report - npm
The new --strict-coverage option enables a more strict coverage reporting where only the flow annotated files are considered as covered (while ...
Read more >
What is Flow Strict? - Educative.io
The Strict flag in Flow sets up files for stricter adherence to rules. The user can choose the rules that need to be...
Read more >
flowtype coverage report is not picking up types I have already ...
Don't know if you should have flow-typed/npm/react-bootstrap_vx.x.x.js . This looks like a stub, which may conflict with 0.32.0?
Read more >
Customize pipeline configuration - GitLab Documentation
If the CI/CD configuration file is on an external site, the URL must end with ... If multiple jobs in the pipeline have...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found