0.7 - Breaking changes
See original GitHub issueThe issue description will be kept up to date reflecting the status and changes
- In order to get the benefits of tree-shaking, and as a first step to splitting into different modules, all the individual components have to be imported by itself
-import { ChartCanvas, Chart, series, scale, coordinates, tooltip, axes, indicator, helper } from "react-stockcharts";
+import { ChartCanvas, Chart } from "react-stockcharts";
-var { CandlestickSeries, BarSeries, LineSeries, AreaSeries } = series;
+import {
+ CandlestickSeries,
+ BarSeries,
+ LineSeries,
+ AreaSeries,
+} from "react-stockcharts/lib/series";
-var { discontinuousTimeScaleProvider } = scale;
+import { discontinuousTimeScaleProvider } from "react-stockcharts/lib/scale";
-var { CrossHairCursor, MouseCoordinateX, MouseCoordinateY, CurrentCoordinate } = coordinates;
+import {
+ CrossHairCursor,
+ CurrentCoordinate,
+ MouseCoordinateX,
+ MouseCoordinateY,
+} from "react-stockcharts/lib/coordinates";
-var { OHLCTooltip, MovingAverageTooltip } = tooltip;
+import {
+ OHLCTooltip,
+ MovingAverageTooltip,
+} from "react-stockcharts/lib/tooltip";
-var { XAxis, YAxis } = axes;
+import { XAxis, YAxis } from "react-stockcharts/lib/axes";
-var { ema, sma, wma, tma } = indicator;
+import { ema, wma, sma, tma } from "react-stockcharts/lib/indicator";
-var { fitWidth } = helper;
+import { fitWidth } from "react-stockcharts/lib/helper";
- Remove the usage of
calculator
, from allXXXSeries
andXXXTooltip
and fromChartCanvas
what this means is that react-stockcharts will not calculate any indicators for you, it has to be done in userland before rendering the chart. There have been many questions about custom indicators and how to use indicators which are calculated on the server. After using the app myself, I think it is more intuitive to provide helpers to calculate indicators, so users can use them if needed (or use their own calculators) and providedata[]
with the precalculated values - Remove
xScaleProvider
fromChartCanvas
so for discontinuous scales, there will be a helper function provided which users can use to create a newxScale
for discontinuous data and provide that as an input inxScale
- Remove the contents of folder
lib/indicator
and movelib/indicator/algorithm/
intolib/indicator
- Investigate Interactive indicators to use canvas (again) Made some good progress on canvas interactives, you can find the work in progress here and here. New features hover, blur, click, drag events for the components. After drawing, click the component to select it and then drag it around. Different components can have different degrees of freedom, see the fib retracement e.g. where the top and bottom retracements move north-south, the edge circles move east-west and the rest of the lines move in all directions
- Interactive indicators to be touch friendly - not doing in 0.7
- In order to fix https://github.com/rrag/react-stockcharts/issues/165 I see no alternative other than to drop svg support, and use html
div/span
for tooltip text - this has been discussed earlier and I am still not certain what I want to do. SVG does not have a float based layout which is necessary to fix #165 - not doing in 0.7
Development of these are happening on the next
branch so please review that before you want to submit any PR. Ideally I want to accept PRs only on the next
branch unless it is for bugfixes to 0.6
without simple workarounds
Issue Analytics
- State:
- Created 7 years ago
- Reactions:6
- Comments:11 (5 by maintainers)
Top Results From Across the Web
What's new in Solidity 0.7? New Features & Breaking Changes
REGISTER FOR EXCLUSIVE PREVIEW OF NEW COURSE "ADVANCED SOLIDITY": https://mailchi.mp/8bd0fd861588/advanced-solidityFull list of changes in ...
Read more >DefaultDocumentation 0.7.0 breaking changes #43 - GitHub
Breaking changes. changed file name generation for FullName and Name FileNameMode. This is due to a pretty bad choice on my part at...
Read more >Changes in Solidity 0.7.0 - General - OpenZeppelin Forum
On July 28th, 2020, the solidity compiler got a minor version bump to 0.7.0. It was accompanied by a release changelog sporting 32...
Read more >Thread: - Version 0.7.0 - BREAKING CHANGES
Version 0.7.0 - BREAKING CHANGES · The previous "AjaxResponse" class has been renamed to "Response". · The previous "ResponseObject" class has ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Huge perf improvement in
next
version upto 30 fps when panning lots of data at 2 points per pixelhttps://www.youtube.com/watch?v=wWbE4KDRggQ
Check it out: http://rrag.github.io/fullpage/documentation.html
Appreciate feedback ping @itsjimbo @WaiSiuKei
@rrag sourcecode is updated last night (UTC+8 Timezone)