question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PR #407 changes the way accessing the mirror works. Using import { mirror } from 'rrweb' to access the mirror doesn’t work anymore. This breaks getMirror() on the rrweb player.

Proposed solution A:

Maybe we can expose the mirror by also adding a getMirror() method on the rrweb replayer to re-enable this behaviour.

Proposed solution B:

Alternatively we can make the mirror attribute public on the replayer instead of private: https://github.com/rrweb-io/rrweb/blob/0f86a72705b998a9abf5b4aae5b01a4f3b679954/src/replay/index.ts#L124

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
Yuyz0112commented, May 24, 2021

@Juice10 Thanks for the report.

I merge this PR because it’s a breaking change and will be released in v1.0.

For general usage, I think solution B is good enough. And I’m also thinking about adding some warning if someone is using import { mirror } from 'rrweb', do you have any ideas about this?

1reaction
Yuyz0112commented, May 25, 2021

@Juice10 Please let me know whether the latest commit works.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Exposed Mirrors-Antique Brass - Global Views
Round antique brass plated mirror. Hangs on a cleat that is provided but gives the illusion that the mirror hangs from a hook....
Read more >
Global Views Exposed Mirror - CLAYTON GRAY HOME
The exposed Mirror from Global Views offers a high-style decorative mirror for your home. This versatile, round, antique-brass plated mirror hangs on a ......
Read more >
Global Views Exposed Mirror - Layla Grayce
$1,497.50 ; Finish: Antique Brass ; Material: MDF, Aluminum, and Mirror ; Size: Large ; Brand: Global Views ; Dimensions: D 48" /...
Read more >
One Piece Security Mirror - Frameless Exposed Mounting
This 12" x 14" security mirror is fabricated from 22 gauge, bright polished stainless steel. It is one-piece and has no frame. It...
Read more >
The Mirror - Expose.news
Secret private investigator emails found in Prince Harry's Mirror phone hacking case. EMAILS between Mirror Group news executives and 14 private investigators ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found