Expose mirror
See original GitHub issuePR #407 changes the way accessing the mirror works. Using import { mirror } from 'rrweb'
to access the mirror doesn’t work anymore. This breaks getMirror() on the rrweb player.
Proposed solution A:
Maybe we can expose the mirror by also adding a getMirror()
method on the rrweb replayer to re-enable this behaviour.
Proposed solution B:
Alternatively we can make the mirror attribute public
on the replayer instead of private
:
https://github.com/rrweb-io/rrweb/blob/0f86a72705b998a9abf5b4aae5b01a4f3b679954/src/replay/index.ts#L124
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Exposed Mirrors-Antique Brass - Global Views
Round antique brass plated mirror. Hangs on a cleat that is provided but gives the illusion that the mirror hangs from a hook....
Read more >Global Views Exposed Mirror - CLAYTON GRAY HOME
The exposed Mirror from Global Views offers a high-style decorative mirror for your home. This versatile, round, antique-brass plated mirror hangs on a ......
Read more >Global Views Exposed Mirror - Layla Grayce
$1,497.50 ; Finish: Antique Brass ; Material: MDF, Aluminum, and Mirror ; Size: Large ; Brand: Global Views ; Dimensions: D 48" /...
Read more >One Piece Security Mirror - Frameless Exposed Mounting
This 12" x 14" security mirror is fabricated from 22 gauge, bright polished stainless steel. It is one-piece and has no frame. It...
Read more >The Mirror - Expose.news
Secret private investigator emails found in Prince Harry's Mirror phone hacking case. EMAILS between Mirror Group news executives and 14 private investigators ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@Juice10 Thanks for the report.
I merge this PR because it’s a breaking change and will be released in v1.0.
For general usage, I think solution B is good enough. And I’m also thinking about adding some warning if someone is using
import { mirror } from 'rrweb'
, do you have any ideas about this?@Juice10 Please let me know whether the latest commit works.