Migration rsocket 1.0.0-RC6 to 1.0.2 breaks functionality

Expected Behavior

The implementation of 1.0.2 should work the same as 1.0.0-RC6

Actual Behavior

When I start the ServerStarter and directly after that the ClientStarter - the publisher subscribes, but no request is sent to the server when subscriber.onComplete(); is called.

The client server roundtrip should work like before (master branch)

The changes I did to migrate from 1.0.0-RC6 to 1.0.2 can be viewed in https://github.com/klopfdreh/rsocket_playground/pull/3/files

Steps to Reproduce

• Check out https://github.com/klopfdreh/rsocket_playground.git (rsocket_1_0_2 branch)
• Run ServerStarter
• Run ClientStarter

Your Environment

See pom.xml rsocket-transport-netty 1.0.2 / rsocket-core 1.0.2

• RSocket version(s) used: 1.0.2

• Other relevant libraries versions (eg. netty, …): netty

• Platform (eg. JVM version (javar -version) or Node version (node --version)): java 13.0.1 2019-10-15 Java™ SE Runtime Environment (build 13.0.1+9) Java HotSpot™ 64-Bit Server VM (build 13.0.1+9, mixed mode, sharing)

• OS and version (eg uname -a): macOS Catalina 10.15.6

[klopfdreh]

@rstoyanchev The rewritten code works like a charm. I just wanted to know what exactly the issue was and as I read the documentation it is more clear to me. 👍

I guess this issue can be labeled as a question and I am going to close it with this comment.

The rework can be seen here:

https://github.com/klopfdreh/rsocket_playground/pull/3/commits/b8bf00c6d6666415fdfc46037ce0db17813d6846

[rstoyanchev]

@klopfdreh yes there were changes and even if the previous version was more lenient, the fact remains that your have a custom Publisher that does not behave according to Reactive Streams rules for a Publisher where a Publisher cannot call onNext before there is a request for more elements through the Subscription given to the Subscriber. Using a known well-behaved Publisher shows that it works as expected.