Py3k error with "unicode" identifier in dotted_toc extension

I’ve seen port to py3K is in progress, thanks a lot for that!

Just in case, I tried launching my pdf build on today’s rst2pdf github master, under python3.7.3, it failed due to this line:

Traceback (most recent call last):
  File "....a\lib\site-packages\reportlab\platypus\flowables.py", line
700, in wrap
    W,H = _listWrapOn(self._content,aW,self.canv,dims=dims)
  File "....\lib\site-packages\reportlab\platypus\flowables.py", line
624, in _listWrapOn
    w,h = f.wrapOn(canv,availWidth,0xfffffff)
  File "....\lib\site-packages\reportlab\platypus\flowables.py", line
125, in wrapOn
    w, h = self.wrap(aW,aH)
  File "....\lib\site-packages\rst2pdf\extensions\dotted_toc.py", line 137, in wrap
    if not isinstance(text, unicode):
NameError: name 'unicode' is not defined

Maybe there is a need for a global search-replace of “unicode” with six utility, to batch-solve this kind?

[tbpassin]

Here’s a simple way around this problem, along with a couple of others )Ihave found in the code:

# rst2pdf hacks for python 3+
unicode = type(str) # all strings in Python 3 are unicode.
unichr = chr # Python 3 equivalent.
basestring = str # see https://www.atemon.com/blog/python-3-unexpected-exception-name-basestring-is-not-defined-when-invoking-ansible2/

Add these statements to the top of the module that is failing, after the imports. Better would be to make these definitions conditional on the Python version, something like this:

try:
   basestring
except NameError:
   basestring = str

[lornajane]

I think we’re fully python3 compatible at this point so this should be solved. Going to close but if anyone has more information please do comment!