editor.action.commentLine key binding not working on Macos

Summary

Currently it appears that one of our default keybindings is colliding with the commentLine command in fresh mac os installs. We should be able to just simply choose a new keybinding for this but I am not 100% sure which one too choose 🤔 .

Work

• Use a different default keybinding for mac users
• Decide on new keybinding by reviewing existing vscode defaults

Dev Triage

https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L192-L195 https://code.visualstudio.com/docs/getstarted/keybindings#_detecting-keybinding-conflicts

---

Original Ticket

Describe the bug Key binding for command editor.action.commentLine doesn’t work anymore on MacOS.

To Reproduce Steps to reproduce the behavior:

1. Install the extension.
2. Try to use editor.action.commentLine command with default key binding command + shift + 7 on a selected portion of code.
3. command is not triggered.

Expected behaviour The command should be triggered and the selected code should be commented.

Desktop (please complete the following information):

• OS: macos
• Extension; Version v2.7.4
• VSCode Versio:n 1.56.2 (Universal)

[ryanluker]

@massicer Thanks for getting back to me with the solution to the mystery hah. Happy coding 😁 .

[massicer]

@ryanluker yes, I also checked my custom keybindings using the tip reported here: https://code.visualstudio.com/docs/getstarted/keybindings#_viewing-modified-keybindings

But I also figured out this issue was caused by my keyboard layout (ITALIAN) since when I set it to USA everything worked well and additionally the keybinding for the command with id editor.action.commentLine changed from cmd+shift+7 to cmd+/.

I suppose this happens since in my layout in order to produce / you have to type shift+7.

I will solve my issue by changing the default keybinding for coverage-gutters.displayCoverage.

Thanks anyway for your support 😊