Not explicit function name
See original GitHub issueIn section Function names should say what they do you’re explicitly saying that you’re adding a month to a date, addMonthToDate()
.
In section Remove duplicate code you’re showing the employees list using showList()
.
Shouldn’t that be showEmployeesList() as well, in order to explicitly tell what will be shown, so you just have to pass the type of the employee as an argument (managers or developers in that context)?
I’m not really sure about it, which is why I wanted to discuss about. Thanks for this great work!
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:7 (5 by maintainers)
Top Results From Across the Web
Explicit Functions: Definition & Examples - Study.com
Explicit functions are functions that are written as one dependent variable in terms of another independent variable.
Read more >explicit specifier - cppreference.com
1) Specifies that a constructor or conversion function (since C++11)or deduction guide (since C++17) is explicit, that is, it cannot be used for ......
Read more >as3 non-explicit function pointer - Stack Overflow
In the code, where it says, "this works", it works as expected. However I need to fire off these formulas, without naming "firstElement" ......
Read more >using for with explicit function names does not support ...
When declaring functions to use with a user-defined type, overloaded functions trigger the error "Identifier not found or not unique".
Read more >explicit-function-return-type | typescript-eslint
Require explicit return types on functions and class methods. ... An array of function/method names that will not have their arguments or return...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
You know what, you’re right. It should say showEmployeesList! Want to make a PR?
I’ll change it to
showEmployeeList()
then. Thanks @hueitan for pointing that out. 😉