question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Not explicit function name

See original GitHub issue

In section Function names should say what they do you’re explicitly saying that you’re adding a month to a date, addMonthToDate().

In section Remove duplicate code you’re showing the employees list using showList().

Shouldn’t that be showEmployeesList() as well, in order to explicitly tell what will be shown, so you just have to pass the type of the employee as an argument (managers or developers in that context)?

I’m not really sure about it, which is why I wanted to discuss about. Thanks for this great work!

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:1
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
ryanmcdermottcommented, Jan 25, 2017

You know what, you’re right. It should say showEmployeesList! Want to make a PR?

0reactions
AnnaNeecommented, Jan 27, 2017

I’ll change it to showEmployeeList() then. Thanks @hueitan for pointing that out. 😉

Read more comments on GitHub >

github_iconTop Results From Across the Web

Explicit Functions: Definition & Examples - Study.com
Explicit functions are functions that are written as one dependent variable in terms of another independent variable.
Read more >
explicit specifier - cppreference.com
1) Specifies that a constructor or conversion function (since C++11)or deduction guide (since C++17) is explicit, that is, it cannot be used for ......
Read more >
as3 non-explicit function pointer - Stack Overflow
In the code, where it says, "this works", it works as expected. However I need to fire off these formulas, without naming "firstElement" ......
Read more >
using for with explicit function names does not support ...
When declaring functions to use with a user-defined type, overloaded functions trigger the error "Identifier not found or not unique".
Read more >
explicit-function-return-type | typescript-eslint
Require explicit return types on functions and class methods. ... An array of function/method names that will not have their arguments or return...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found