@Metered not working on Spring MVC Controller

Hi there,

I tried to add @Metered to a Spring MVC Controller but do not get any metrics. I read the section about Spring AOP limitations but not sure if this the problem in this case.

My Spring configuration below and the annotations I added to the controller method. Is there any other configuration or annotations required to make this work?

<metrics:metric-registry id="metrics" />
<metrics:health-check-registry id="healthCheck" />

<metrics:annotation-driven metric-registry="metrics" health-check-registry="healthCheck" />

<metrics:reporter type="slf4j" metric-registry="metrics" period="1m" />

<metrics:register metric-registry="metrics">
  <bean metrics:name="jvm.gc" class="com.codahale.metrics.jvm.GarbageCollectorMetricSet" />
  <bean metrics:name="jvm.memory" class="com.codahale.metrics.jvm.MemoryUsageGaugeSet" />
</metrics:register>

and my MVC Controller is annotated like this:

@Controller
public class BlaController {

    @Timed
    @Counted
        @Metered
    @ResponseBody
    @RequestMapping(value = "bla", method = RequestMethod.POST, produces = APPLICATION_JSON_VALUE, consumes = APPLICATION_JSON_VALUE)
    public SomeResponse bla(@RequestBody Request request) {
      // do something I want to measure
    }

}

Many thanks for pointers. Niels

[bertramn]

Thanks a million, I did have indeed a subcontext in my web application. Adding the <metrics:annotation-driven /> element to the dispatcher context did the trick. Do you think it would be worth adding a little note about this to the README? Somethign like below:

If your spring application uses nested spring contexts and each context loads classes annotated with metrics annotations, add the <metrics:annotation-driven /> directive to each spring context configuration. This will ensure all metrics annotated classes are registered for metrics collection. A typical example is a spring mvc web application. You may configure the metrics registry and reporters in the main web application context whilst metered controllers are defined in the dispatch servlet context.

the application wide context file applicationContext.xml contains the metrics setup and may also load metered services:

<beans>
  <!-- application wide metrics configuration -->
  <metrics:metric-registry id="metrics" />
  <metrics:annotation-driven metric-registry="fancy-metrics" />
  <metrics:reporter type="slf4j" metric-registry="fancy-metrics" period="1m" />
  <!-- metered services here --->
</beans>

and in the dispatcher servlet specific context file api-v1-dispatcher-servlet.xml repeat the annotation driven configuration:

<beans>
  <!-- ensures that all controllers in this subcontext are registered -->
  <metrics:annotation-driven metric-registry="fancy-metrics" />
  <!-- metered controllers here --->
</beans>

[joakimhop]

I had a similar issue. This saved my day!