generational backup misbehaving?

Hi, I think I ran into an issue. I configured the configurational backup. (Thanks for the amazingly fast implementation btw!)

I used the following configuration:

{
  "max_snapshots_in_hassio": 3,
  "max_snapshots_in_google_drive": 30,
  "days_between_snapshots": 1,
  "use_ssl": false,
  "send_error_reports": true,
  "generational_days": 6,
  "generational_weeks": 3,
  "generational_months": 11,
  "generational_years": 10
}

While it started good (4th of april, next 11th of april), I afterwards still have all my daily backups in Google drive. Shouldn’t it delete everythung but 18th and 25th?

Or am I missunderstanding the behaviour? Does it start deleting only if it gets to the max limit? But then, why did it “work” at the beginning.

Clearly, it’s no serious bug as no data is lost, I’m just wondering if something is wrong or I just don’t understand.

[sabeechen]

Here’s an option I hadn’t thought of, I could just make it configurable. Like add a checkbox for “Purge Generational Snapshots Early”, where when you check it snapshots get cleaned up if they’re not associated with one of the time-frames associated with a generational snapshot even if you have the space available in Google Drive. That would have the added benefit of being “opt-in”, so anyone that already had generational backups enabled wouldn’t suddenly see their snapshots disappear when they update the add-on.

[sabeechen]

Took me a loooong while to get to this, but I’ve added an option to “aggressively” clean up old snapshots with generational backup in v0.99.0. You can check for it under “Keep Generational Backups” in the settings menu.