question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Missing landmark on select options

See original GitHub issue

Current behaviour

After opening select and checking with axe plugin it fails All page content should be contained by landmarks rule:

image

Expected behaviour

After opening select it should not fail All page content should be contained by landmarks rule.

CodeSandbox or Storybook URL

https://codesandbox.io/s/festive-panka-oi2mw?file=/src/index.js

JIRA Ticket (Sage Only)

RIV-527

Suggested Solution

No response

Carbon Version

87.0.1

What browsers are you seeing the problem on?

Chrome

What Operating System are you seeing the problem on?

MacOS, Windows

Anything else we should know?

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
nicktitchmarshcommented, May 24, 2022

@tempertemper I am going to create a different issue with your above comment and look for solutions.

1reaction
tempertempercommented, Oct 5, 2021

Probably not the answer you’ll be looking for, but I don’t think this should be given a landmark…

Giving the dropdown it its own landmark wouldn’t quite make sense because it’s not an individual, identifiable page landmark like a header, footer, call to action, etc. – it’s part of a form control.

Also, it’s content that you can reach with a screen reader without removing focus from the input, but it’s after the second ‘Hello Carbon’ button in the source order, which is a bit disorienting, especially when there’s a lot more content between the form control and the bottom of the page.

So the ideal fix for this would be to insert it alongside the text <input> that triggers it in the DOM. That way it:

  • would be contained by the same main landmark, or whatever sub-landmark the whole form’s a part of
  • will appear in context for screen reader users who manage to read ‘into’ the dropdown itself, leaving focus on the input
Read more comments on GitHub >

github_iconTop Results From Across the Web

How tpsdig2 estimates missing landmarks?
Actually as far I know, the tpsdig does not estimates missing landmarks. When you use the option "next landmark is missing", it computes...
Read more >
ARIA: listbox role - Accessibility - MDN Web Docs - Mozilla
The listbox role is used for lists from which a user may select one or more items ... All selected options have aria-selected...
Read more >
geomorph.pdf
For ANOVA-based functions, the option to choose among different ... To digitize a missing landmark, simply click on any location in the ...
Read more >
How to Add a Location or Missing Place in Google Maps
Tap the info bar that appears at the bottom of the screen to open it. 4. Tap Add a missing place at the...
Read more >
BigWarp
If a row is “missing” a moving (target) landmark point, then it must be selected in order to add that missing point by...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found