Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add Edit Dialog pattern

See original GitHub issue

Do not use `EditDialog` within a full page form/record layout. This not a replacement for Inline Edit.

It is meant for standalone “modify this word” parts of a page.

This is not an Inline Edit pattern, but does have a similar UX pattern. If you were using an InlineEdit pattern outside a form, then this Edit Dialog variant of input is the replacement component. An Inline Edit UX pattern within a form is A COMPLETELY DIFFERENT THING and is outside the scope of this Github issue. You should go look at #1395

DSR’s Inline Edit Form Input is a different pattern than https://www.lightningdesignsystem.com/components/form-element/#Inline-Edit

Current InlineEdit component should be deprecated. [DONE]
There is no close or cancel on blur with the new examples. ~Inline Edit appears to be upgrade path to Fuel UX’s Placard pattern, but this should be discouraged.~ [DONE]
~Deprecation warning of current InlineEdit should point to a new Popover example on the doc site that shows an edit icon triggering a Popover with a base Input within it.~ [DONE]
~An example of a Inline Edit Form that swaps a read-only Input (that has a right-aligned edit icon on it) for a Base variant Input should be added to Input. Example should look like https://www.lightningdesignsystem.com/components/form-element/#View-Mode and https://www.lightningdesignsystem.com/components/form-element/#Edit-Mode (this is a different issue and outside scope of this issue, that should be considered a new Form component with a docked footer)~ #1395

~We’ll need to do this in consideration of https://github.com/salesforce/design-system-react/issues/273 which involves moving components/form/InlineEdit to components/InlineEdit, but in agreement with this issue should not be moved. It should be “removed” from the doc site and deprecated.~ [DONE]

This is NOT a breaking change.