CookieJar.setCookie does not slide expiration for set-cookie headers with max-age

The creation time from old-cookie is carried forward per the spec, but this causes the expiryTime() to be unaffected by subsequent set-cookie headers, so the cookie will expire when its creation + max-age > now, even if subsequent set-cookie headers specified max-age with the intent of making the expiration now + max-age.

I’m currently working around this by just having a Store implementation that passes null to the callback, so that the creation is not carried forward.

[awaterma]

We’ll discuss this in our next meeting of the team; I’ll try my best to look into this before hand. 😃

Thanks for asking about this @byroncoetsee and @ricellis

[byroncoetsee]

For anyone landing here, and looking for a simple workaround while this issue gets looked at, here’s what I did. NOTE: Doing it this way will drop things like creationIndex etc. It essentially recreates the cookie from scratch - and in doing so, sets the creationDate to now.

class CustomMemoryCookieStore extends MemoryCookieStore {
    updateCookie(oldCookie: Cookie, newCookie: Cookie, cb: (err: Error | null) => void): void
    updateCookie(oldCookie: Cookie, newCookie: Cookie): Promise<void>;
    updateCookie(_: any, newCookie: any, cb?: any): void | Promise<void> {
        newCookie.creation = new Date()
        this.putCookie(newCookie, cb)
        if (cb == null) {
            return Promise.resolve()
        }
    }
}