[BUG] sysctl.present broken in FreeBSD

          ID: security.jail.sysvipc_allowed
    Function: sysctl.present
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/local/lib/python3.7/site-packages/salt/state.py", line 2154, in call
                  *cdata["args"], **cdata["kwargs"]
                File "/usr/local/lib/python3.7/site-packages/salt/loader.py", line 2085, in wrapper
                  return f(*args, **kwargs)
                File "/usr/local/lib/python3.7/site-packages/salt/states/sysctl.py", line 117, in present
                  update = __salt__["sysctl.persist"](name, value, config, ignore)
              TypeError: persist() takes from 2 to 3 positional arguments but 4 were given

Looks like it was broken by this https://github.com/saltstack/salt/pull/55719 since the author of that commit didn’t do any testing or review on any platform other than linux.

[ari]

Well, if it were me I’d revert the whole of the patch that broke it so that author could rewrite it a safe way without assuming that Linux is the only operating system. I don’t understand why this feature would be added at all to the generic sysctl.py codebase. What problem did it solve, why does it exist, what does it do?

[asomers]

That’s an untenable situation. Separately maintaining that change will be maintenance-intensive. Why won’t you simply revert the change that introduced the breakage?