Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

v3 and multiple instances

See original GitHub issue

The new version exports only Plyr which has no setup method.

Issue Analytics

State:
Created 6 years ago
Reactions:1
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

sampottscommented, Mar 3, 2018

Yep, .setup() was removed in favour of a proper class and one to one relationship with element vs instance. It was getting a little messy with allowing whatever in and then spitting out an array with one or many instances back. This way is cleaner and as you’ve found out if a developer wants to setup multiple players it’s as easy as…

const players = Array.from(document.querySelectorAll('.js-player')).map(player => new Plyr(player));

The example is just to show a NodeList is accepted as a value. It doesn’t necessarily make it the best for any scenario. It’s really because I added support for passing jQuery objects which are always an array of elements as I’m sure you know.

I’ll update the docs to make this a little clearer.

1reaction

fridaycommented, Mar 2, 2018

Then don’t use NodeList…